[Rule Request]: Prohibiting use of aria-hidden and role='presentation' on focusable elements. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kddnewton , @vhoyer. Could you please reiview this PR? Any feedback you provide would be greatly appreciated. |
|
Hey, could you add a new line at the end of the files that do not have them? github adds a little 🚫 at the end of the file when that's the case |
vhoyer
approved these changes
Jul 15, 2024
|
but prettier is complaining about your formatting, can you pls fix the problems before we merge it? |
|
Hey @vhoyer. fixed both of them. do check it. |
|
the docs both seem to still have the final EOL problem |
|
Hey. not sure what happened earlier. i have added it again for those. |
|
|
okay i believe it should be resolved now. have a look. |
vhoyer
approved these changes
Jul 16, 2024
| @@ -0,0 +1,39 @@ | |||
| import type { Rule } from "eslint"; | |||
| // import type { AST } from "vue-eslint-parser"; | |||
There was a problem hiding this comment.
it would be better if we removed the comments, no?
vhoyer
approved these changes
Jul 17, 2024
vhoyer
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tion' on focusable elements. (#1169) * Added rule for prohibiting use of aria-hidden and role=presentaion on focusable elements * Refactored code into seprate files and utility file * Added EOL for files with prettier errors * Removed nested ifs * Fixed EOL errors * Added more lines * Fixed prettier issues * Removed commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-hiddenorrole=presentationon focusable elements #85